Use C++20 for KvikIO main library#819
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.10from Sep 12, 2025
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 83283ab |
madsbk
approved these changes
Sep 12, 2025
Contributor
Author
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 15, 2025
## Background `libcurl` have two path parameters related to the certificate authority (CA): - `CURLOPT_CAINFO`, which specifies the CA bundle file path. - `CURLOPT_CAPATH`, which specifies the directory of individual CA certificates with hash-based naming. The default paths are determined at compile-time, which can cause issues if the Linux distributions where `libcurl` is built and run are different (e.g. on Rocky Linux vs Ubuntu as in our CI vs our lab system), and the certificates files are likely at different locations. This problem has been observed in KvikIO's wheel distribution, where HTTPS would fail with the message: >error setting certificate verify locations: CAfile: /etc/pki/tls/certs/ca-bundle.crt CApath: /etc/ssl/certs ## This PR This PR addresses this problem. The certificate path is now explicitly searched for in the following order. The compile-time parameters, if any, are still used but treated with lowest priority. - CA bundle file: Check env vars `CURL_CA_BUNDLE`, and `SSL_CERT_FILE` - CA directory: Check env vars `SSL_CERT_DIR` - CA bundle file: Search a set of distribution-specific locations for accessible bundle - CA directory: Search a set of distribution-specific locations for accessible directory - CA bundle file: Check if the compile-time path is given and accessible - CA directory: Check if the compile-time parameter is given and accessible Depends on #819 for the use of `static` structured binding which is only available in C++ >=20 Closes #711 Authors: - Tianyu Liu (https://github.com/kingcrimsontianyu) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) URL: #817
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR #749 forgets to bring the entrée to the table: Only the C++ code in tests and benchmarks use C++20, but not the main library. This PR fixes this oversight.